Fix colormap import error in python2#321
Merged
ocefpaf merged 1 commit intopython-visualization:masterfrom Jan 10, 2016
Merged
Conversation
Member
And a better reviewer. That @ocefpaf guy did not test this right... |
ocefpaf
added a commit
that referenced
this pull request
Jan 10, 2016
Fix colormap import error in python2
Merged
sanga
pushed a commit
to sanga/folium
that referenced
this pull request
Oct 24, 2017
Fix colormap import error in python2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to play with colormap in python2 ; I got bad surprises.
This is to fix this.
BTW ; this shows that we need tests for colormap. I'll add them in this PR soon.